docker(byoc): add default entrypoint, set log level to INFO, fix custom node blacklist#464
Merged
docker(byoc): add default entrypoint, set log level to INFO, fix custom node blacklist#464
Conversation
Collaborator
Author
|
@pschroedl This is the first PR for comfystream to merge. It simply provides a docker entrypoint for byoc with a few small adjustments |
eliteprox
changed the title
ad-astra-video
approved these changes
Nov 7, 2025
Collaborator
ad-astra-video
left a comment
ad-astra-video
left a comment
There was a problem hiding this comment.
My only comment would be to clear the ORCH_SECRET environment variable after pulling for registration so its not available to custom nodes.
Collaborator
Author
|
FWIW I think registration should be a pytrickle StreamProcessor arg sent to StreamServer to run on startup. I added it in here to get things working quickly |
Collaborator
Author
Collaborator
Author
|
Note: /bin/bash should now be executed interactively using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a default entrypoint and cmd to the base dockerfile for BYOC
blacklist_nodesblacklist_custom_nodesbyoc.pyfrom 8889 to 8000